Conversation
Was added in #294
File names are not case sensative on windows, but are on other platforms causing issues. Fixes #310
This matches the old behavior since you wouldn't have both selection types at the same time before. Fixes #305.
On windows `handleInput` handles the native menu bar, and updates are notified directly after. On non-windows, the custom menubar is used but doesn't immediately notify, causing a desync in state in gui tick. Calling notify after custom menubar mimics the native menu, and doesn't cause any issues on windows as no changes would have happened anyway.
- Add null & bounds check on getChart(index) - Add missing chart null check on list height calculation. - Reuse loop pattern from onDraw for onTick Fixes #338.
These have never appeared in any build (even 2017), as the grab texture has never been defined. Due to SDL changes, this now causes a black rectangle to appear due to null texture.
Fixes issue where the only notes are Mines/Fakes/Warped Notes results in a note count of 0 and then divides by 0 resulting in a bar height of -MAX_INT. Also skip drawing a bar when there's no notes as the height should be 0px anyway. Fixes #342.
This requires notes to function correctly, so check for them.
Attempting to deselect while a region is active causes the start of the region to reset to row 0, but leaves the flag active, resulting in the start of the region being moved to the start. Fixes #346.
It should clear both set and mid selection of regions. ¯\_(ツ)_/¯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ongoing draft for currently reported issues. Each commit is a separate bug fix.
Rename Class noteskin
File names are not case sensative on windows, but are on other platforms they are causing issues.
Fixes #310.
Clear selection region on paste.
This matches the old behavior since you couldn't have both selection types at the same time.
Fixes #305.
Call notify changes after menubar inputs.
On windows
handleInput()handles the native menu bar, and updates are notified directly after.On non-windows, the custom menubar is used but doesn't immediately notify, causing a desync in state in gui tick.
Calling notify after custom menubar mimics the native menu, and doesn't cause any issues on windows as no farther changes could have occured.
ChartList & getChart.
Add null & bounds check on
getChart(index).Add missing chart null check on list height calculation.
Fixes #338.
Remove broken grab textures on ScrollList.
These have never appeared in any build (even 2017), as the grab texture has never been defined.
Due to SDL changes, this now causes a black rectangle to appear due to null texture.
Fix Chart NPS when 0 playable notes.
Fixes issue where when the only notes are Mines/Fakes/Warped Notes, this results in a note count of 0 and then divides by 0 resulting in a bar height of -MAX_INT.
Also skip drawing a bar when there's no notes as the height should be 0px anyway.
Fixes #342.
Prevent setCursorToStream crash.
This requires notes to function correctly, so check for them.
Fixes #344.
Reset region selection flag.
Attempting to deselect while a region is active causes the start of the region to reset to row 0, but leaves the flag active, resulting in the start of the region being moved to the start.
Fixes #346.