Update rhoso-gitops docs for automated sync and dedicated namespace - #713
Update rhoso-gitops docs for automated sync and dedicated namespace#713cjeanner wants to merge 2 commits into
Conversation
|
Hi @cjeanner. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Converting to draft: we must first get validatedpatterns-sandbox/rhoso-gitops#16 in |
|
Both PR are merged on the VP side - time to update the documentation. |
pinikomarov
left a comment
pinikomarov
left a comment
There was a problem hiding this comment.
one comment otherwise looks good
| | automated | ||
| |=== | ||
|
|
||
| All applications include a default retry policy (5 retries with exponential |
There was a problem hiding this comment.
This is too tight. In local CI runs, OLM image pulls from registry.redhat.io took 5-15 minutes depending on load. 9.5 minutes is marginal — it would pass on a fast pull, fail on a slow one.
Recommendation: limit: 10 with maxDuration: 3m
i.e.
10 retries with exponential backoff, starting at 30 seconds and capping at 3 minutes per attempt, for a total retry window of approximately 22 minutes) to handle transient failures during deployment convergence.
There was a problem hiding this comment.
Fun, I didn't have that issue over my numerous runs. Though this is completely customizable. I propose to NOT talk about the actual values of the retries, in case we change the defaults in the VP itself?
There was a problem hiding this comment.
Removed the default numbers, added an example showing how to override the retries.
Child applications now use automated sync with a retry policy by default. Document the targetRevision stability warning, add a section for disabling automated sync, and update the apps table with a Sync column. Update all namespace references from openshift-gitops to rhoso-gitops-standalone to reflect the dedicated ArgoCD instance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
After testings, it seems we don't need to set sync-waves at the application level. This allows to be closer to Validated Patterns "eventually converging" practices. Depends-On: validatedpatterns-sandbox/rhoso-gitops#17
1ce0723 to
762f8b5
Compare
2 participants
Child applications now use automated sync with a retry policy by default. Document the targetRevision stability warning, add a section for disabling automated sync, and update the apps table with a Sync column. Update all namespace references from openshift-gitops to rhoso-gitops-standalone to reflect the dedicated ArgoCD instance.