Data 2938 add get extended properties - #80
Open
Shrikey wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Ported from the deprecated wherescape.py in wherescape-warehouse. Adapted to use parameterized SQL and the logging/raise error handling used by the rest of the class. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BFJonk
reviewed
Aug 12, 2026
| WHERE UPPER(def.epd_variable_name) = UPPER(?)""" | ||
|
|
||
| try: | ||
| result = self.query_meta(sql, [object_name, object_name, object_name, property_name]) |
Contributor
There was a problem hiding this comment.
nitpick: replacing the explicit placements by '?' in the query is a choice. I wouldn't have made it. readability of the query did not improve.
|
|
||
| Looks for a property value on the object itself, its source connection | ||
| and its target connection (in that order). Returns an empty string if | ||
| the property is not set. |
BFJonk
reviewed
Aug 12, 2026
| [dependency-groups] | ||
| dev = [ | ||
| "ruff>=0.15.15", | ||
| "ruff>=0.16.2", |
Contributor
There was a problem hiding this comment.
this MR should be closed: #75
Others should be executed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data 2938 add get extended properties