Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s linting toolchain to ESLint 10 and replaces eslint-plugin-import with eslint-plugin-import-x (due to ESLint 10 compatibility), plus adds a handful of new lint rules and makes small code adjustments to satisfy them across the monorepo.
Changes:
- Bumped ESLint ecosystem dependencies to ESLint
^10.6.0(incl.@eslint/js) and refreshed the lockfile accordingly. - Switched import ordering from
eslint-plugin-importtoeslint-plugin-import-xand updated the flat config rule/plugin wiring (import-x/order). - Added a few style rules (e.g.
prefer-template) and updated a couple of call sites to use template literals.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates dependency graph for ESLint 10 + eslint-plugin-import-x and related transitive deps. |
| package.json | Bumps ESLint + swaps eslint-plugin-import → eslint-plugin-import-x. |
| eslint.config.js | Updates plugin wiring/rule prefix to import-x/* and adds new lint rules. |
| pipeline/test/update-prismic-snapshots.ts | Replaces string concatenation with a template literal (aligns with new lint rules). |
| common/services/logging.ts | Replaces string concatenation with a template literal (aligns with new lint rules). |
| api/scripts/holiday_closure_test.ts | Replaces string concatenation with a template literal (aligns with new lint rules). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rcantin-w
marked this pull request as ready for review
August 25, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Update to eslint 10, change ordering package as the one we like currently doesn't support eslint 10 (import-js/eslint-plugin-import#3278)
Decided to add some rules we recently added to wc.org, just for alignment. It didn't need much changes!
How to test
yarn && yarn lintHave we considered potential risks?
N/A, pretty mild, dev changes.