Skip to content

Update to eslint10, switch order plugin package and add some rules - #397

Open
rcantin-w wants to merge 1 commit into
mainfrom
eslint-10
Open

Update to eslint10, switch order plugin package and add some rules#397
rcantin-w wants to merge 1 commit into
mainfrom
eslint-10

Conversation

@rcantin-w

Copy link
Copy Markdown
Contributor

What does this change?

Update to eslint 10, change ordering package as the one we like currently doesn't support eslint 10 (import-js/eslint-plugin-import#3278)

Decided to add some rules we recently added to wc.org, just for alignment. It didn't need much changes!

How to test

yarn && yarn lint

Have we considered potential risks?

N/A, pretty mild, dev changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s linting toolchain to ESLint 10 and replaces eslint-plugin-import with eslint-plugin-import-x (due to ESLint 10 compatibility), plus adds a handful of new lint rules and makes small code adjustments to satisfy them across the monorepo.

Changes:

  • Bumped ESLint ecosystem dependencies to ESLint ^10.6.0 (incl. @eslint/js) and refreshed the lockfile accordingly.
  • Switched import ordering from eslint-plugin-import to eslint-plugin-import-x and updated the flat config rule/plugin wiring (import-x/order).
  • Added a few style rules (e.g. prefer-template) and updated a couple of call sites to use template literals.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yarn.lock Updates dependency graph for ESLint 10 + eslint-plugin-import-x and related transitive deps.
package.json Bumps ESLint + swaps eslint-plugin-importeslint-plugin-import-x.
eslint.config.js Updates plugin wiring/rule prefix to import-x/* and adds new lint rules.
pipeline/test/update-prismic-snapshots.ts Replaces string concatenation with a template literal (aligns with new lint rules).
common/services/logging.ts Replaces string concatenation with a template literal (aligns with new lint rules).
api/scripts/holiday_closure_test.ts Replaces string concatenation with a template literal (aligns with new lint rules).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@rcantin-w
rcantin-w marked this pull request as ready for review August 25, 2026 11:44
@rcantin-w
rcantin-w requested a review from a team as a code owner August 25, 2026 11:44
@rcantin-w rcantin-w moved this to Ready for review in Digital experience Aug 25, 2026
@rcantin-w rcantin-w added the Lower priority Prioritise other PRs over this one unless it's getting old label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Lower priority Prioritise other PRs over this one unless it's getting old

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants