Skip to content

Exclude dynamic informer compatibility test - #34

Merged
zhouguangyuan0718 merged 1 commit into
xgo-dev:mainfrom
zhouguangyuan0718:codex/exclude-dynamic-informer
Aug 20, 2026
Merged

Exclude dynamic informer compatibility test#34
zhouguangyuan0718 merged 1 commit into
xgo-dev:mainfrom
zhouguangyuan0718:codex/exclude-dynamic-informer

Conversation

@zhouguangyuan0718

Copy link
Copy Markdown
Collaborator

The deterministic compatibility log identified k8s.io/client-go/dynamic/dynamicinformer as the active package when the hosted runner terminated with exit 143.

Exclude that package and regenerate the pinned manifest. It is replaced by k8s.io/client-go/transport, keeping the contract at exactly 200 unique packages.

Validation:

  • go test ./cmd/bent
  • python3 -m unittest discover -s ci/llgo-compatibility -p "test_*.py"
  • bash -n ci/llgo-compatibility/run.sh
  • git diff --check

@zhouguangyuan0718
zhouguangyuan0718 merged commit b6e3cda into xgo-dev:main Aug 20, 2026
1 check failed

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: exclude dynamic/dynamicinformer from llgo-compatibility

This is a clean, low-risk configuration change. It adds k8s.io/client-go/dynamic/dynamicinformer to the Exclude list in ci/llgo-compatibility/projects.toml and regenerates cmd/bent/configs/benchmarks-llgo-compatibility.toml accordingly.

Verified:

  • The generated bent config change is exactly what generate_manifest.py produces from the projects.toml change: excluding one package from the alphabetically-sorted top-45 window shifts every subsequent client_go Repo up by one and pulls k8s.io/client-go/transport into slot client_go_045.
  • Invariants hold — 45 client_go entries, 200 total [[Benchmarks]], Limit sum = 200. No duplicate Name/Repo collisions.
  • The Exclude list stays alphabetically ordered; dynamicinformer is inserted in the correct position.
  • Config-only change: no runtime code, no supply-chain surface change (module/URL/version @v0.36.2 unchanged), values are safely encoded by the generator. No security or performance concerns.

One minor, non-blocking note left inline regarding the exclusion rationale.

Exclude = [
"k8s.io/client-go/discovery/cached/disk",
"k8s.io/client-go/discovery/cached/memory",
"k8s.io/client-go/dynamic/dynamicinformer",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (non-blocking): this new entry inherits the blanket comment above the list ("failed the Go baseline or LLGo dependency discovery in the first full hosted run"). That reason is disjunctive and generic, so it's only accurate if dynamicinformer actually failed for one of those two causes. Consider confirming the specific failure mode in the PR description (or a per-entry note) so this compatibility-contract change stays auditable later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant