feat(cli): prover config file - #881
Open
ColoCarletti wants to merge 3 commits into
Open
Conversation
One file consolidates what was spread across CLI flags, env vars and hardcoded constants: [prove] blowup/epoch_size_log2, [tables] per-table row caps (log2), [scheduler] table_parallelism/vram_budget_mb, and [gpu] thresholds and kill-switches. The file is a diff over the code defaults — every key optional, unknown keys rejected — with precedence CLI flag > env var > file > default, so existing scripts are unaffected. Ships docs/prover.example.toml (fully commented, defaults annotated) and a full-coverage parse fixture.
ColoCarletti
force-pushed
the
prover-config-file
branch
from
July 31, 2026 13:04
ca8bcb1 to
39e7d59
Compare
diegokingston
approved these changes
Jul 31, 2026
# Conflicts: # prover/src/continuation.rs
Oppen
reviewed
Jul 31, 2026
| file_cfg.prove.epoch_size_log2.map(|v| { | ||
| parse_epoch_size_log2(&v.to_string()).unwrap_or_else(|e| { | ||
| eprintln!("config [prove].epoch_size_log2: {e}"); | ||
| std::process::exit(2); |
Collaborator
There was a problem hiding this comment.
Shouldn't this be an ExitCode::FAILURE?
Oppen
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
cli prove --config prover.toml(also on verify, for blowup): a single TOML profile for the prover's tuning knobs, which today are spread across env vars and hardcoded constants. Proofs are unaffected, these knobs only shape how the work is scheduled and split.The file is a diff over the code defaults: every key is optional, machine-computed defaults (cores, VRAM) stay computed, and unknown keys are rejected so typos fail loudly.