London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book Library by mandipsanger · Pull Request #569 · CodeYourFuture/Module-Data-Flows

mandipsanger · 2026-08-20T10:55:09Z

Self cheklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
Sprint 2 Data flows book library

cjyuan

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

mandipsanger · 2026-08-21T11:33:39Z

My Program is working now but failing checks Validate PR Metadata workflow run.

mandipsanger · 2026-08-21T11:39:48Z

its showing Validate PR Metadata
2s
Run args=("/tmp/pr-metadata-validator")

thread 'main' (2352) panicked at src/bin/pr-metadata-validator.rs:74:6:
Failed to validate PR: UserFacing("Failed to parse issue #571 - no submit label.\n\nIf this issue was made my a curriculum team member it should be given a sprint label.\nIf this issue was created by a trainee for step submission, it should probably be closed (and they should create the issue in their fork).")
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Error: Process completed with exit code 101.
do you have any idea

cjyuan · 2026-08-21T12:38:36Z

        <label for="pages">Pages:</label>
        <input
          type="number"
          class="form-control"
          id="pages"
          name="pages"
+          min="1"
+          step="1"
          required
        />


The browser checks the input elements against the specified constraints only when a user submits a form.
Without <form>, the browser won't enforce the constraints like required or min="1".

please check some changes i have made

cjyuan · 2026-08-21T12:39:01Z

        <label class="form-check-label">
          <input
            type="checkbox"
            class="form-check-input"
            id="check"
-            value=""
-          />Read
+          />
+          Read
        </label>


This checkbox is not showing.

The issue is related to Bootstrap 4.4.1. Could you use AI to find a way to fix the issue? Mentioning "Bootstrap 4.4.1" might help.

cjyuan · 2026-08-21T12:39:43Z

          type="submit"
          value="Submit"
          class="btn btn-primary"
          onclick="submit();"


Could you lookup the trade off between

Assigning event listener in HTML

Assigning event listener in JS via .addEventListener()

cjyuan · 2026-08-21T12:40:01Z

@@ -1,46 +1,64 @@
 let myLibrary = [];


Could we declare myLibrary in a way that prevents it from being accidentally reassigned?

cjyuan · 2026-08-21T12:43:00Z

+    title.value,
+    author.value,
+    pages.value,


These are raw input.

What if title.value is " Some title " or " "? What if pages.value is "00030" or "3e1"? These values could pass the checks on lines 30 and 38.

cjyuan · 2026-08-21T12:45:07Z

 const title = document.getElementById("title");
 const author = document.getElementById("author");
 const pages = document.getElementById("pages");
 const check = document.getElementById("check");


Could you name these variables to emphasise that they are input elements?

cjyuan · 2026-08-21T12:45:41Z

+  title.value = "";
+  author.value = "";
+  pages.value = "";
+  check.checked = false;


If these input elements are in a form, we could just call a form's method to reset all elements.

cjyuan · 2026-08-21T12:47:21Z

+  for (let n = rowsNumber - 1; n > 0; n--) {
    table.deleteRow(n);
  }


Could you look up a more efficient approach (than deleting table rows one by one) to clear the <tbody> part of a table?

cjyuan · 2026-08-21T12:48:54Z

      alert(`You've deleted title: ${myLibrary[i].title}`);
+
      myLibrary.splice(i, 1);
      render();


The alert message is shown before the book is actually deleted; the deletion only occurs after the alert dialog is dismissed. This introduces a risk that the operation may not complete (e.g., if the user closes the browser before dismissing the alert).

In general, it’s better to display a confirmation message only after the associated operation has successfully completed.

alert() is a blocking function call. As a result, invoking it prevents the browser from updating the UI until the dialog is dismissed.

If time permits, research for approaches that allows the UI to update before displaying the alert dialog. (This is an optional change).

mandipsanger added 3 commits August 20, 2026 10:30

book lilbrary fix bug

97c6d21

book library debugging

16fa264

fix changes

3013701

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

adding file

597ab64

mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026

mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026

mandipsanger added 3 commits August 20, 2026 18:11

adding relevant files

291e346

adding files

8bf9a93

adding title to html

269f218

cjyuan reviewed Aug 20, 2026

View reviewed changes

cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 20, 2026

fixing validation issue

e686370

mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 21, 2026

cjyuan reviewed Aug 21, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 21, 2026

mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026

mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026

Uh oh!

Uh oh!

Conversation

mandipsanger commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

mandipsanger commented Aug 21, 2026

Uh oh!

mandipsanger commented Aug 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mandipsanger commented Aug 20, 2026 •

edited

Loading