-
-
Notifications
You must be signed in to change notification settings - Fork 275
London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book Library #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mandipsanger
wants to merge
10
commits into
CodeYourFuture:main
Choose a base branch
from
mandipsanger:book-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+166
−117
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
97c6d21
book lilbrary fix bug
mandipsanger 16fa264
book library debugging
mandipsanger 3013701
fix changes
mandipsanger 597ab64
adding file
mandipsanger 291e346
adding relevant files
mandipsanger 8bf9a93
adding files
mandipsanger 269f218
adding title to html
mandipsanger e686370
fixing validation issue
mandipsanger 10d0aba
response to feedback
mandipsanger 030e4f9
changes
mandipsanger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,78 @@ | ||
| let myLibrary = []; | ||
| const myLibrary = []; | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const readInput = document.getElementById("check"); | ||
| const form = document.getElementById("form"); | ||
|
|
||
| window.addEventListener("load", function () { | ||
| populateStorage(); | ||
| render(); | ||
|
|
||
| if (form) { | ||
| form.addEventListener("submit", function (event) { | ||
| event.preventDefault(); | ||
| submit(); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| true | ||
| if (myLibrary.length === 0) { | ||
| // Initialize sample data with two books | ||
| myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true)); | ||
|
|
||
| myLibrary.push( | ||
| new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| // Get cleaned input values | ||
| const titleValue = titleInput.value.trim(); | ||
| const authorValue = authorInput.value.trim(); | ||
| const pagesValue = pagesInput.value.trim(); | ||
|
|
||
| // Check for empty input fields | ||
| if (!titleValue || !authorValue || !pagesValue) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| return; | ||
| } | ||
|
|
||
| // Make sure pages contains digits only | ||
| if (!/^\d+$/.test(pagesValue)) { | ||
| alert("Number of pages needs to be a valid integer greater than 0!"); | ||
| return; | ||
| } | ||
|
|
||
| // Convert pages to a number | ||
| const pageNumber = Number(pagesValue); | ||
|
|
||
| // Check that pages is greater than zero | ||
| if (pageNumber <= 0) { | ||
| alert("Number of pages needs to be a valid integer greater than 0!"); | ||
| return; | ||
| } | ||
|
|
||
| // Create a new book using cleaned and validated values | ||
| const newBook = new Book( | ||
| titleValue, | ||
| authorValue, | ||
| pageNumber, | ||
| readInput.checked | ||
| ); | ||
|
|
||
| // Add the new book | ||
| myLibrary.push(newBook); | ||
|
|
||
| // Update the display | ||
| render(); | ||
|
|
||
| // Reset the entire form | ||
| if (form) { | ||
| form.reset(); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -51,53 +84,56 @@ function Book(title, author, pages, check) { | |
| } | ||
|
|
||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| const table = document.getElementById("display"); | ||
| const rowsNumber = table.rows.length; | ||
|
|
||
| // Remove existing rows except header | ||
| for (let n = rowsNumber - 1; n > 0; n--) { | ||
| table.deleteRow(n); | ||
| } | ||
|
Comment on lines
+91
to
93
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you look up a more efficient approach (than deleting table rows one by one) to clear the |
||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
|
|
||
| for (let i = 0; i < myLibrary.length; i++) { | ||
| const row = table.insertRow(); | ||
|
|
||
| // Insert book information | ||
| row.insertCell().innerText = myLibrary[i].title; | ||
| row.insertCell().innerText = myLibrary[i].author; | ||
| row.insertCell().innerText = myLibrary[i].pages; | ||
|
|
||
| // Read/Unread button | ||
| const readCell = row.insertCell(); | ||
|
|
||
| const changeBut = document.createElement("button"); | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| changeBut.innerText = myLibrary[i].check ? "Yes" : "No"; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| render(); | ||
| }); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| readCell.appendChild(changeBut); | ||
|
|
||
| // Delete button | ||
| const deleteCell = row.insertCell(); | ||
|
|
||
| const delBut = document.createElement("button"); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| delBut.innerText = "Delete"; | ||
|
|
||
| delBut.addEventListener("click", function () { | ||
| const deletedTitle = myLibrary[i].title; | ||
|
|
||
| // Delete the book first | ||
| myLibrary.splice(i, 1); | ||
|
|
||
| // Update the display | ||
| render(); | ||
|
|
||
| // Show confirmation after deletion | ||
| alert(`You've deleted title: ${deletedTitle}`); | ||
| }); | ||
|
|
||
| deleteCell.appendChild(delBut); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,5 +15,5 @@ | |
| } | ||
|
|
||
| button.btn-info { | ||
| margin: 20px; | ||
| margin: 30px; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Could also consider using
Number.isInteger()on line 54 instead of using regular expression on line 45.