London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library - #570
London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library#570vmoratti wants to merge 11 commits into
Conversation
vmoratti
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Could you also check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
| id="title" | ||
| name="title" | ||
| required | ||
| /> |
There was a problem hiding this comment.
The browser checks the input elements against the specified constraints only when a user submits a form.
Without <form>, the browser won't enforce the "required" constraint.
There was a problem hiding this comment.
Why not make this input element to accept only positive whole number?
There was a problem hiding this comment.
This checkbox is not showing.
The issue is related to Bootstrap 4.4.1. Could you use AI to find a way to fix the issue? Mentioning "Bootstrap 4.4.1" might help.
cjyuan
added
Reviewed
2 participants
Self checklist
Changelist
I fixed all the "bugs" and also run it through the Lighthouse tool for accessibility with 94% success.