Skip to content

London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmoratti wants to merge 17 commits into
base: main
Choose a base branch
from
+214 −148
Open

London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ee2cff9
fix syntax error on line 57
vmoratti Aug 20, 2026
6bed9db
on line 41 not 'library', 'myLibrary', and 'title.value' is repeated
vmoratti Aug 20, 2026
44d9dea
deleteButton was inconsistent variable, change to deleteBut, change c…
vmoratti Aug 20, 2026
a963df2
add <title> , and lang='en'
vmoratti Aug 20, 2026
3df5e43
fix <meta>, add extra <meta>
vmoratti Aug 20, 2026
50a35c6
add defer to sccript links
vmoratti Aug 20, 2026
08dd57c
add main tag
vmoratti Aug 20, 2026
2073970
add author validation conditions,
vmoratti Aug 20, 2026
8ad6617
change delete button details
vmoratti Aug 20, 2026
e6bd736
Refactor HTML structure and improve form layout
vmoratti Aug 21, 2026
1bb9eae
Change book management and some forms
vmoratti Aug 21, 2026
718d34c
refactor beek-library
vmoratti Aug 21, 2026
16396b5
add styling
vmoratti Aug 21, 2026
ec7bc67
make changes after run through html validator and after general feedback
vmoratti Aug 21, 2026
2f8d0cb
just done merge as something gone wrong
vmoratti Aug 21, 2026
1b1390e
second attempt
vmoratti Aug 21, 2026
7560fea
refactor book handling, and deletion delay
vmoratti Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions debugging/book-library/.vscode/settings.json
View file
Open in desktop

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common practice is to exclude local configuration files, which typically differ between developers, from a PR branch unless the configuration is required for the changes to work.

To ignore a tracked file such as .vscode/settings.json locally, use:

git update-index --skip-worktree path/to/file

And if you ever need undo the operation in order to track it again, use:

git update-index --no-skip-worktree path/to/file

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5501
}
190 changes: 114 additions & 76 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta
name="description"
content="Keep track of the books you've read."
/>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<script
src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"
defer
></script>
<script
src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"
defer
></script>
<script
src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"
defer
></script>

<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
Expand All @@ -18,79 +33,102 @@
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<main>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button
data-toggle="collapse"
data-target="#demo"
class="btn btn-info"
aria-expanded="false"
aria-controls="demo"
>
Add new book
</button>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div id="demo" class="collapse">
<form id="book-form">
<div class="form-group">
<p><span class="text-danger">*</span> Required fields</p>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<label for="title">
Title:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
/>

<label for="author">
Author:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>

<label for="pages">
Pages:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>

<div class="form-check">
<input
type="checkbox"
class="form-check-input"
id="check"
/>
<label class="form-check-label" for="check">
Read
</label>
</div>

<button
type="submit"
class="btn btn-primary"
>
Submit
</button>
</div>
</form>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>

<tbody>
</tbody>
</table>
</main>

<script src="script.js"></script>
<script defer src="script.js"></script>
</body>
</html>
</html>
151 changes: 83 additions & 68 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,58 @@
let myLibrary = [];

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we declare myLibrary in a way that prevents it from being accidentally reassigned?


window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);

const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);

myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
// Get the form and its input elements
const bookForm = document.getElementById("book-form");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");

// Add a new book when the form is submitted
bookForm.addEventListener("submit", function (event) {

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider defining the event listener as a named function, and then
placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

Doing so makes it easier to locate and manage all the code that runs once when the app starts.

// Stop the page from refreshing when the form is submitted
event.preventDefault();

// Browser validation checks the required fields and page number
if (!bookForm.checkValidity()) {
bookForm.reportValidity();
return;
}
}

const book = new Book(
titleInput.value.trim(),
authorInput.value.trim(),
Comment on lines +43 to +44

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What f titleInput.value is " "? Could a book title or author's name be an empty string?

Number(pagesInput.value),
checkInput.checked
);

myLibrary.push(book);

render();

// Clear the form after adding the book
bookForm.reset();
});

function Book(title, author, pages, check) {
this.title = title;
Expand All @@ -51,53 +62,57 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
const tableBody = document.querySelector("#display tbody");

// Delete the old rows before rendering the updated list
tableBody.innerHTML = "";

for (let i = 0; i < myLibrary.length; i++) {
const row = tableBody.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

// Add the book information to the table
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

// Add a button for changing the read status
const changeButton = document.createElement("button");

changeButton.className = "btn btn-success";
changeButton.textContent = myLibrary[i].check ? "Yes" : "No";

wasReadCell.appendChild(changeButton);

changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
// Add a delete button to the row
const deleteButton = document.createElement("button");

deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";

deleteCell.appendChild(deleteButton);

deleteButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

myLibrary.splice(i, 1);

render();

// Show the message after the book has been removed
setTimeout(function () {
alert(`You've deleted title: ${deletedTitle}`);
}, 3);

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 3 (or 0.5) ? What difference does it make?

});
}
}
Loading
Loading