Skip to content

fix(guest): isolate local key providers from KMS inventory - #954

Merged
kvinwang merged 1 commit into
codex/fix-guest-kms-failover-orderfrom
codex/fix-guest-local-provider-inventory
Aug 5, 2026
Merged

fix(guest): isolate local key providers from KMS inventory#954
kvinwang merged 1 commit into
codex/fix-guest-kms-failover-orderfrom
codex/fix-guest-local-provider-inventory

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

STACKED PR — merge #946 first.

Problem

Local key-provider entries were mixed into the remote KMS inventory and passed through KMS failover logic. A local provider could be treated as an unreachable KMS endpoint or reorder remote selection.

Root cause and fix

Keep local providers in their own path and build the failover inventory only from actual KMS endpoints.

Implementation

The branch records the following focused implementation work:

  • fix(guest): isolate local key providers from KMS inventory
  • style(guest): format provider route test

Changed paths:

  • dstack/dstack-util/src/system_setup.rs

Scope

This PR addresses one logical guest finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

Verification

  • git diff --check origin/codex/fix-guest-kms-failover-order..origin/codex/fix-guest-local-provider-inventory: passed.
  • The declared base was verified as an ancestor of the PR head.
  • Focused compile/check verification was run for the changed component where applicable; non-Rust packaging or configuration changes were reviewed against their exact branch delta.

Copilot AI review requested due to automatic review settings July 31, 2026 03:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-guest-local-provider-inventory branch from 894a162 to eb91609 Compare July 31, 2026 03:26
@kvinwang
kvinwang force-pushed the codex/fix-guest-local-provider-inventory branch from eb91609 to ac918d6 Compare August 5, 2026 09:21
@kvinwang kvinwang changed the title [STACKED on #946] fix(guest): isolate local key providers from KMS inventory fix(guest): isolate local key providers from KMS inventory Aug 5, 2026
@kvinwang
kvinwang force-pushed the codex/fix-guest-local-provider-inventory branch from ac918d6 to cbb6665 Compare August 5, 2026 09:22
@kvinwang
kvinwang merged commit 438254e into codex/fix-guest-kms-failover-order Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants