Skip to content

New workflow for external then internal review - #4968

Merged
frjo merged 11 commits into
mainfrom
feature/workflow-external-internal-review
Sep 1, 2026
Merged

New workflow for external then internal review#4968
frjo merged 11 commits into
mainfrom
feature/workflow-external-internal-review

Conversation

@frjo

@frjo frjo commented Aug 26, 2026

Copy link
Copy Markdown
Member

This is a new workflow for organisations that do the external review before the internal review.

Also added two bug fixes:

  1. The status label background colour did not work for languages other than English.
  2. Inconsistent naming, "Ready For…" vs "Ready for…". All workflows now use the later.

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Aug 26, 2026
@frjo
frjo requested a review from wes-otf August 26, 2026 08:41
@frjo

frjo commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

This is work for a new Hypha adopter. Will merge it in after we confirmed it works as it should.

With this PR Hypha will have six workflows. Any more and we should start thinking about adding a way to enable/disable workflows. Then an organisation can pick the two or three workflows they use and staff will have an easier time creating funds and labs.

@frjo
frjo force-pushed the feature/workflow-external-internal-review branch from 781eb3c to ece9c7f Compare August 27, 2026 12:16
@frjo
frjo force-pushed the feature/workflow-external-internal-review branch 2 times, most recently from ece9c7f to 58bb1b2 Compare August 28, 2026 06:12
frjo added 3 commits August 31, 2026 22:55
  -> ext_int_screened so get_review_statuses do not catch it. Other minor fixes and ajustments.
@frjo
frjo merged commit 520344a into main Sep 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant