refactor: move the smtp option parsing into a pure class - #6
Merged
vitormattos merged 1 commit intoSep 26, 2026
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5.
The two decisions the plugin makes on its options, whether
smtp_authmeans "on" and whether an SSL option turns a certificate check on, off or leaves the default, were written inline in thephpmailer_initcallback, so they could only be tested through WordPress.src/OptionValue.php, two pure static methods:smtp_auth()keeps the existing rules (TRUE,ON,1,OK, any non-zero number), andssl()returnstrue,falseornullfor "keep the PHP default". The main file loads the class withrequire_once; the Composer autoloader only serves PHPUnit and PHPStan.librecode_simple_smtp_mail_sender()now only reads the options and hands them toOptionValue.phpunit.xml.dist,composer test:unit) that runs without WordPress or a database, with named data providers for both methods.composer testruns unit, then integration.No behaviour change: the integration suite from #5 passes unchanged.
composer cipasses with 31 unit and 38 integration tests.