Skip to content

fix(agent-sessions): remove the Repeated calls check - #1196

Merged
JeremyFunk merged 1 commit into
mainfrom
fix/remove-repeated-calls-check
Oct 1, 2026
Merged

JeremyFunk merged 1 commit into
mainfrom
fix/remove-repeated-calls-check

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Removes the "Repeated calls" row from the agent session checklist.

  • Drops the repetition finding kind and its detector (8 calls of one tool in a turn, or 3 identical calls in a row).
  • Drops the checklist row and the coverage copy that referred to it.
  • Removes the tests that covered it.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes
    • Session reports no longer include checks or findings for repeated tool calls, including consecutive calls with identical arguments. Provider retry, truncation, and stall findings remain available.
    • Updated coverage explanations to avoid attributing tool-payload reads to repeated calls and to remove claims that identical retries cannot be distinguished. The turns explanation no longer links the one-turn-per-trace estimate to repeated calls.

@maple-review-bot

maple-review-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 5/5 · safe to merge
A removal with no dangling consumer: a repo-wide grep for repetition at the head returns nothing but unrelated text.
quality 100/100 · no findings · tests not needed · risk low

Removes the "Repeated calls" check end to end: the repetition finding kind and its detector, the checklist row, and the coverage copy that named it. The deletion is complete and safe to merge.

  • buildSessionFindings no longer emits repetition findings
  • repetitionCheck dropped from buildSessionChecks
  • SessionFindingKind narrows to providerRetry | truncation | stall
  • Coverage copy no longer cites Repeated calls
What was checked
  • canonicalJSON is still imported where used; its only other callers are in @maple/query-engine
  • No remaining reference to repetition, the check id, or its constants anywhere at the head
  • isCountedToolCall is still used by session-checks.ts:204 and session-summary.ts:894

eebeff0 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c4c32549-f305-4937-a672-a36c90eef078

📥 Commits

Reviewing files that changed from the base of the PR and between 5a6085d and eebeff0.

📒 Files selected for processing (5)
  • apps/web/src/components/agent-sessions/session-detail/session-checks.tsx
  • packages/agent-sessions/src/session-checks.test.ts
  • packages/agent-sessions/src/session-checks.ts
  • packages/agent-sessions/src/session-findings.test.ts
  • packages/agent-sessions/src/session-findings.ts
💤 Files with no reviewable changes (3)
  • packages/agent-sessions/src/session-findings.test.ts
  • packages/agent-sessions/src/session-checks.test.ts
  • packages/agent-sessions/src/session-checks.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The session findings and checks no longer detect or report repeated tool calls. The related tests are removed, and the session-check explanations no longer refer to repetition checks.

Changes

Repeated-call reporting removal

Layer / File(s) Summary
Remove repetition findings
packages/agent-sessions/src/session-findings.ts, packages/agent-sessions/src/session-findings.test.ts
The findings builder no longer detects repeated tool calls or includes repetition findings. The repetition finding kind and its test are removed.
Remove the repeated-calls check
packages/agent-sessions/src/session-checks.ts, packages/agent-sessions/src/session-checks.test.ts, apps/web/src/components/agent-sessions/session-detail/session-checks.tsx
The session check builder no longer adds the repeated-calls check. Its helper and tests are removed, and the UI explanations no longer refer to repetition checks.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to eebef

Session reports intentionally stop assessing repeated tool calls. The related checklist and explanations are updated consistently, with no actionable merge-blocking risk identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to eebef

The inspected change removes advisory repeated-call reporting rather than a tool-execution restriction. No security finding was established. Compatibility with consumers expecting the removed finding kind remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The demonstrated impact is reduced visibility of repeated calls in session findings and the web checklist. The inspected path does not establish increased tool authority, credential access or cross-tenant reachability.

Trust Boundaries and Controls

  • observed — The inspected finding producer and check consumer calculate advisory results from captured telemetry. Neither function executes tools, grants authority or denies an operation, so removing repetition reporting is not demonstrated to bypass an enforcement control.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Repeated calls check from agent sessions. It matches the PR objectives and affected code.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JeremyFunk
JeremyFunk merged commit 7dfa83e into main Oct 1, 2026
41 checks passed
@JeremyFunk
JeremyFunk deleted the fix/remove-repeated-calls-check branch October 1, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant