Conversation
This was referenced Sep 17, 2026
Member
|
Hum, why still I would have done that: |
Contributor
Author
|
I kept the change deliberately narrow and guarded only the operation causing the reported regression, preserving the existing |
The watermark module receives metadata and tag change signals in every darkroom session, even when it is disabled. Refreshing its pixelpipe cache and clearing mipmap_hash then causes unnecessary work and repeated thumbnail generation. Ignore both signals while the module is disabled. This keeps enabled watermark text responsive to metadata changes while avoiding invalidation for other images. Regression from darktable-org#22103, unreleased.
radialmonster
force-pushed
the
agent/watermark-invalidate-only-when-enabled
branch
from
September 17, 2026 16:46
b33619f to
9d2993a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the thumbnail-regeneration regression from #22103 for images
that don't use the watermark module: its metadata/tag signal callbacks
are connected in every darkroom session, not just when watermark is
enabled.
This checks
self->enabledat the callback boundary, so a disabledwatermark skips both
dt_iop_refresh_all()anddt_history_hash_unset_mipmap(). Images without watermark enabled keepa synced hash and stop regenerating their thumbnail on every darkroom
visit.
Built and tested against current master: no-op darkroom visits for
images without watermark remain synced and do not regenerate their
thumbnail. Images with watermark enabled still regenerate on every
visit after this change; this was flagged and accepted as a known
tradeoff in the discussion on #22103.
Prepared with AI assistance.