Conversation
jmchilton
force-pushed
the
test-job-files-in-tmpdir
branch
from
September 22, 2026 17:38
9013da6 to
8681c1c
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jmchilton
force-pushed
the
test-job-files-in-tmpdir
branch
from
September 22, 2026 22:20
8681c1c to
7d084de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1438.
Motivation
When a workflow test embeds its job definition directly in the test YAML, Planemo currently serializes that job to a temporary JSON file beside the test definition. This briefly modifies the source checkout and requires the source directory to be writable.
#1438 correctly proposed moving these generated files to the system temporary directory. However, the location of a job file is also the base directory for relative test-data paths, so moving the file without preserving that base breaks inputs such as
path: hello.txt.Changes
FileandDirectorypaths against the original test-definition directory before serialization.pathparameters, and the original in-memory test definition unchanged.Validation
test_galaxy_workflow_nested_collection_inputsagainst a real managed Galaxy, exercising nested collections whose inputs use relativehello.txtpaths.git diff --checkfor the changed files.