Show ToC when there is at least 1 heading - #13743
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
dotcom-rendering/src/model/enhanceTableOfContents.test.ts:63
- Consider adding a test case that has exactly one valid h2 heading (i.e. using a SubheadingBlockElement) to verify that the ToC is correctly returned.
it('will not return a toc if there are no h2s', () => {
|
Size Change: 0 B Total Size: 959 kB ℹ️ View Unchanged
|
DanielCliftonGuardian
approved these changes
Apr 8, 2025
DanielCliftonGuardian
left a comment
DanielCliftonGuardian
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Why one H2 and not two ? Seems redundant to show a toc for one item.
arelra
approved these changes
Apr 8, 2025
Contributor
Author
Thanks for the review Daniel, I agree a one-item ToC doesn't really make sense but I don't see any harm leaving this up to the user. I'll leave it in as it's what Rich asked for 👍 |
|
Seen on PROD (merged by @simonbyford 10 minutes and 3 seconds ago) Please check your changes! |
groakland
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Reduces the minimum number of headings required to trigger a table of contents from 3 to 1.
Why?
We got this request from Rich:
Screenshots