Skip to content

Show ToC when there is at least 1 heading #13743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonbyford merged 1 commit into from
Apr 8, 2025
Merged

Show ToC when there is at least 1 heading #13743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions dotcom-rendering/src/model/enhanceTableOfContents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,15 @@ describe('Enhance Table of Contents', () => {
]);
});

it('will not return a toc if the are fewer than 3 h2s', () => {
it('will not return a toc if there are no h2s', () => {
const input: Block[] = [
{
...blockMetaData,
elements: [
{
_type: 'model.dotcomrendering.pageElements.SubheadingBlockElement',
elementId: 'h2One',
html: '<h2>This is the h2 text</h2>',
},
{
_type: 'model.dotcomrendering.pageElements.SubheadingBlockElement',
elementId: 'h2Two',
html: '<h2>This is the h2 text</h2>',
_type: 'model.dotcomrendering.pageElements.TextBlockElement',
elementId: 'text',
html: 'Text',
},
],
},
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/model/enhanceTableOfContents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,5 +112,5 @@ export const enhanceTableOfContents = (
}
}

return tocItems.length >= 3 ? tocItems : undefined;
return tocItems.length >= 1 ? tocItems : undefined;
};
Loading