Skip to content

Validate DorogayaSet input bounds #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krotname wants to merge 1 commit into from
Closed

Validate DorogayaSet input bounds #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions src/main/java/algorithms/sprint6/DorogayaSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,14 @@
public class DorogayaSet {

static final String FAIL = "Oops! I did it again";
private static final int MAX_VERTICES = 200_000;
private static final int MAX_EDGES = 200_000;

static long solve(int n, Edge[] edges) {
if (!isValidGraph(n, edges)) {
return -1;
}

Arrays.sort(edges, (a, b) -> Integer.compare(b.weight, a.weight));

DSU dsu = new DSU(n);
Expand All @@ -69,6 +75,24 @@ static long solve(int n, Edge[] edges) {
return totalWeight;
}

private static boolean isValidGraph(int n, Edge[] edges) {
if (n < 1 || n > MAX_VERTICES || edges == null || edges.length > MAX_EDGES) {
return false;
}

for (Edge edge : edges) {
if (edge == null || !isValidVertex(edge.from, n) || !isValidVertex(edge.to, n)) {
return false;
}
}

return true;
}

private static boolean isValidVertex(int vertex, int n) {
return vertex >= 1 && vertex <= n;
}

static final class Edge {
final int from;
final int to;
Expand Down Expand Up @@ -236,17 +260,28 @@ private static void run() throws Exception {
int n = in.nextInt();
int m = in.nextInt();

Edge[] edges = new Edge[m];
long answer = -1;

for (int i = 0; i < m; i++) {
int from = in.nextInt();
int to = in.nextInt();
int weight = in.nextInt();
if (n >= 1 && n <= MAX_VERTICES && m >= 0 && m <= MAX_EDGES) {
Comment thread
krotname marked this conversation as resolved.
Edge[] edges = new Edge[m];
boolean validEdges = true;

edges[i] = new Edge(from, to, weight);
}
for (int i = 0; i < m; i++) {
int from = in.nextInt();
int to = in.nextInt();
int weight = in.nextInt();

if (!isValidVertex(from, n) || !isValidVertex(to, n)) {
validEdges = false;
}

edges[i] = new Edge(from, to, weight);
}

long answer = solve(n, edges);
if (validEdges) {
answer = solve(n, edges);
}
}

if (answer == -1) {
out.writeString(FAIL);
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/algorithms/AlgorithmCliTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ private static Stream<Arguments> stdioCases() {
arguments("algorithms.sprint6.DorogayaSet", "run",
"4 4%n1 2 5%n1 3 6%n2 4 8%n3 4 3%n".formatted(),
"19%n".formatted()),
arguments("algorithms.sprint6.DorogayaSet", "run",
"5 -1%n".formatted(),
"Oops! I did it again%n".formatted()),
arguments("algorithms.sprint6.DorogayaSet", "run",
"2 1%n3 1 42%n".formatted(),
"Oops! I did it again%n".formatted()),
arguments("algorithms.sprint6.WaterWorld", "run",
"3 3%n#.#%n.#.%n#.#%n".formatted(),
"5 1%n".formatted()),
Expand Down
Loading