[cheriot,rtl] Integrate TRVK filter into Ibex Top - #2456
Merged
andreaskurth merged 1 commit intoAug 11, 2026
Conversation
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
4 times, most recently
from
June 30, 2026 09:35
9a2ee2d to
748b234
Compare
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
2 times, most recently
from
June 30, 2026 13:24
f8eaaff to
8348e15
Compare
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
20 tasks
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
from
July 1, 2026 06:24
8348e15 to
c2bd352
Compare
andreaskurth
reviewed
Jul 3, 2026
andreaskurth
left a comment
andreaskurth
left a comment
Contributor
There was a problem hiding this comment.
Mostly LGTM, thanks @thommythomaso!
A few comments/suggestions below
thommythomaso
marked this pull request as ready for review
July 27, 2026 09:23
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
2 times, most recently
from
July 29, 2026 07:56
6f6b73e to
0eaeb4d
Compare
SamuelRiedel
reviewed
Aug 3, 2026
SamuelRiedel
left a comment
SamuelRiedel
left a comment
Contributor
There was a problem hiding this comment.
I rebased my work on top and things worked fine. I only had one minor issue.
andreaskurth
reviewed
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Thanks @thommythomaso! I have a couple more comments :-) Please see below.
One comment that doesn't attach inline: on rtl/ibex_top.sv:1523: The MajorAlertOnDMemIntegrityErr assertion pairs the downstream trigger data_rvalid_i with the core-side data data_rdata_core. When the TRVK response FIFO already holds an entry those are different words, so the assertion decodes the wrong one, no? Independently, the ##[0:5] window could be exceeded while the TRVK stalls a response for a bitmap lookup (although unlikely in our current systems). Would triggering on trvk_rvalid be the right fix?
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
7 times, most recently
from
August 10, 2026 05:52
228a6a2 to
adc11b5
Compare
nasahlpa
reviewed
Aug 10, 2026
andreaskurth
left a comment
andreaskurth
left a comment
Contributor
There was a problem hiding this comment.
Thanks @thommythomaso, this addresses everything from the last round. Just one thing left, below.
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
from
August 10, 2026 20:07
adc11b5 to
5e2c7c8
Compare
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
from
August 10, 2026 20:22
5e2c7c8 to
c148089
Compare
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/cheriot-ibex-int
branch
from
August 11, 2026 11:06
c148089 to
d7d679d
Compare
andreaskurth
approved these changes
Aug 11, 2026
andreaskurth
left a comment
andreaskurth
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @thommythomaso!
andreaskurth
removed this pull request from the merge queue due to the queue being cleared
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #2455 and it integrates the TRVK filter into Ibex.
Currently the TRVK filter is not operated in lockstep, an issue is opened here: #2467.
The TRVK filter is not yet verified in the Ibex repo, see #2466.