Skip to content

feat: port test_general core to CTS - #72

Open
bavulapati wants to merge 1 commit into
nodejs:mainfrom
bavulapati:feat/port-test-general
Open

feat: port test_general core to CTS#72
bavulapati wants to merge 1 commit into
nodejs:mainfrom
bavulapati:feat/port-test-general

Conversation

@bavulapati

Copy link
Copy Markdown
Contributor

Ports the stable core of test/js-native-api/test_general: test.js, testGlobals.js, testNapiRun.js, testNapiStatus.js.

Two deliberate differences from upstream:

  • testGetVersion() is compared against the harness napiVersion global rather than the hardcoded 10.
  • node_api_set_prototype is left out; it is experimental and lands as its own addon in a follow-up, so this addon stays loadable on every runtime.

First of several small PRs for this directory (testInstanceOf, V8 instanceof, testFinalizer, testEnvCleanup, setPrototype follow). PORTING.md moves to Partial until they all land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Need Triage

Development

Successfully merging this pull request may close these issues.

1 participant