src: require watchdog status pointers - #64667
Open
Archkon wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
Archkon
force-pushed
the
watchdog
branch
3 times, most recently
from
July 22, 2026 07:48
c7b0efa to
78d9f11
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64667 +/- ##
==========================================
+ Coverage 90.15% 90.29% +0.13%
==========================================
Files 744 759 +15
Lines 242517 247648 +5131
Branches 45688 46693 +1005
==========================================
+ Hits 218642 223606 +4964
- Misses 15358 15516 +158
- Partials 8517 8526 +9
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Jul 24, 2026
Contributor
Author
|
@avivkeller Could you apply request-ci for this pr? |
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
Author
|
@avivkeller Could you take a look at these failed tests ? |
Member
|
Looks like a rebasing issue |
Archkon
force-pushed
the
watchdog
branch
2 times, most recently
from
July 26, 2026 17:37
133715b to
518698c
Compare
Contributor
Author
|
@avivkeller Rebased, and you need to apply request-ci again |
Contributor
Author
|
@avivkeller Could you apply request-ci for this? |
jasnell
reviewed
Aug 2, 2026
Remove the nullptr defaults from Watchdog and SigintWatchdog result parameters. Both watchdogs unconditionally dereference these pointers, so callers must explicitly provide valid status storage. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the nullptr defaults from Watchdog and SigintWatchdog result parameters. Both watchdogs unconditionally dereference these pointers, so callers must explicitly provide valid status storage.