Skip to content

fix: Clarify "Remove unavailable layers" button confirmation dialog - #67402

Open
DelazJ wants to merge 2 commits into
qgis:masterfrom
DelazJ:unhandledLayers
Open

DelazJ wants to merge 2 commits into
qgis:masterfrom
DelazJ:unhandledLayers

Conversation

@DelazJ

@DelazJ DelazJ commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The dialog message let's think that the "Remove unavailable layers" still keep the layers in the project while it really drops them. The current description is instead the behavior of the "Keep unavailable layers" button.
Should fix #55107 if I understood the full expectations.

Description

[Replace this with some text explaining the rationale and details about this pull request]

AI tool usage

  • AI tool(s) (Copilot, Claude, or something similar) supported my development of this PR. See our policy about AI tool use. Use of AI tools must be indicated. Failure to be honest might result in banning.

The dialog message let's think that the "Remove unavailable layers" still keep the layers in the project while it really drops them. The current description is instead the behavior of the "Keep unavailable layers" button.
Fixes qgis#55107
@github-actions github-actions Bot added this to the 4.4.0 milestone Sep 11, 2026
Comment thread src/app/qgshandlebadlayers.cpp Outdated
this,
tr( "Unhandled layer will be lost." ),
tr( "There are still %n unhandled layer(s). If they are not fixed, they will be disabled/deactivated until the project is opened again.", "unhandled layers", mLayerList->rowCount() ),
tr( "There are still %n unhandled layer(s). If they are not fixed, they will be removed from the project and lost when the project is saved.", "unhandled layers", mLayerList->rowCount() ),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove the and lost when the project is saved part (it should be an obvious behaviour and anyway it is a behaviour not related to that button).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also adding a permanently... There are still %n unhandled layer(s). If they are not fixed, they will be permanently removed from the project.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, this was my initial change. And I started to think: "and if...? And if...?" Will adjust then. Thanks @agiudiceandrea.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
To execute locally, unzip the downloaded zip file and run bin\qgis-bin.exe in the extracted directory.
You might be prompted by Windows Defender click "Run anyway"
(Built from commit 4cbbf35)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 4cbbf35)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing naming of "remove unavailable layers" button

2 participants