Skip to content

fix: Clarify "Remove unavailable layers" button confirmation dialog #67402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyalldawson merged 2 commits into from
Sep 28, 2026
Merged

fix: Clarify "Remove unavailable layers" button confirmation dialog #67402

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec758d4
fix: Clarify "Remove unavailable layers" button confirmation dialog
DelazJ Sep 11, 2026
4cbbf35
Be clear and less verbose
DelazJ Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/qgshandlebadlayers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ void QgsHandleBadLayers::accept()
&& QMessageBox::warning(
this,
tr( "Unhandled layer will be lost." ),
tr( "There are still %n unhandled layer(s). If they are not fixed, they will be disabled/deactivated until the project is opened again.", "unhandled layers", mLayerList->rowCount() ),
tr( "There are still %n unhandled layer(s). If they are not fixed, they will be removed from the project and lost when the project is saved.", "unhandled layers", mLayerList->rowCount() ),

@agiudiceandrea agiudiceandrea Sep 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove the and lost when the project is saved part (it should be an obvious behaviour and anyway it is a behaviour not related to that button).

@agiudiceandrea agiudiceandrea Sep 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also adding a permanently... There are still %n unhandled layer(s). If they are not fixed, they will be permanently removed from the project.

@DelazJ DelazJ Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny, this was my initial change. And I started to think: "and if...? And if...?" Will adjust then. Thanks @agiudiceandrea.

QMessageBox::Ok | QMessageBox::Cancel,
QMessageBox::Cancel
) == QMessageBox::Cancel )
Expand Down
Loading